Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file_max_bytes configuration for azure logging endpoint #398

Merged

Conversation

kellymclaughlin
Copy link
Contributor

Support file_max_bytes configuration option for azure blob storage logging endpoint. Follows from fastly/go-fastly#255.

@Integralist
Copy link
Collaborator

@kellymclaughlin you'll need to run make generate-docs to get the last CI check to pass.

@Integralist Integralist added the enhancement New feature or request label Apr 16, 2021
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just need the CI to pass, which requires running make generate-docs.

Support file_max_bytes configuration option for azure blob storage logging
endpoint.
@kellymclaughlin kellymclaughlin force-pushed the azure-logging-file-max-bytes branch from beecdc6 to 88ff2a0 Compare April 16, 2021 14:42
@kellymclaughlin
Copy link
Contributor Author

Thanks @Integralist! I forgot about make generate-docs, but took care of that now.

@Integralist Integralist merged commit 178a5f6 into fastly:master Apr 19, 2021
@kellymclaughlin kellymclaughlin deleted the azure-logging-file-max-bytes branch April 19, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants