Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support usage of IAM role in S3 and Kinesis logging endpoints #403

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

kellymclaughlin
Copy link
Contributor

  • Add the ability to specify an IAM role for the S3 and Kinesis logging endpoints
  • Bump go-fastly to v3.6.0

Follows from fastly/go-fastly#269.

* Add the ability to specify an IAM role for the S3 and Kinesis logging endpoints
* Bump go-fastly to v3.6.0
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change request, but otherwise looks good.

@Integralist Integralist added the enhancement New feature or request label Apr 21, 2021
@Integralist Integralist merged commit dbdc203 into fastly:master Apr 23, 2021
@jeffwecan
Copy link

@Integralist: Apologies for potentially misappropriating this PR's comments. Also, do y'all have any general timeline for when a release containing these additions will land (and/or any published documentation on this provider's release timeline / cadence)?

@kellymclaughlin kellymclaughlin deleted the aws-iam-role-support branch April 30, 2021 18:03
@Integralist
Copy link
Collaborator

Hi @jeffwecan 👋🏻

Apologies for potentially misappropriating this PR's comments

That's OK 🙂

Apologies for the slow reply, but I've been away on leave. I'll be cutting a new release this morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants