Update default initial value for health check. #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmarcotte
force-pushed
the
dm-healthcheck-initial
branch
from
2bd5d9f to
30b08ae
Compare
Takes into account the change where the VCL is lazy-loaded on nodes as needed. The lazy-load may cause the first couple of health check attempts to fail, and can be enough to mark the backend as unhealthy until enough successful checks occur to reach the threshold again. It is highly recommended that the initial and threshold values be the same for health checks going forward. By setting the initial value to equal the threshold value, the threshold will be met immediately, before any Health check requests are sent. The backend is initialized as Healthy from the start. This avoids unnecessary errors as the VCL is being loaded onto the nodes.
derekmarcotte
force-pushed
the
dm-healthcheck-initial
branch
from
30b08ae to
fe3ecf9
Compare
|
I can't approve this, but I do want to suggest that this be changed. |
|
Thanks @HawkSE I'll get this approved and merged. Once merged I'll need to coordinate this change with a new Terraform release, which might not happen immediately as we usually like to bundle up a few different changes within a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes into account the change where the VCL is lazy-loaded on nodes as
needed. The lazy-load may cause the first couple of health check
attempts to fail, and can be enough to mark the backend as unhealthy
until enough successful checks occur to reach the threshold again.
It is highly recommended that the initial and threshold values be the
same for health checks going forward.