Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use ParallelTest for no_auth data source #449

Merged
merged 3 commits into from
Jul 22, 2021

Conversation

smaeda-ks
Copy link
Contributor

@smaeda-ks smaeda-ks commented Jul 22, 2021

... when running full acceptance tests.

https://www.terraform.io/docs/language/providers/configuration.html#default-provider-configurations

It looks like when tests are running in parallel to the IP ranges data source test, sometimes, other tests are getting polluted with an instance of the provider with no API key.

Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @bengesoff could you please give a 👍🏻 here once the local running of the test suite has finished and is showing as passing. Thanks!

@bengesoff
Copy link
Contributor

@Integralist unfortunately a 👎🏼 but having some possible luck with changing ParallelTest to Test

@bengesoff
Copy link
Contributor

The tests look good with the ParallelTest replacement - the alias stuff doesn't appear to be needed. I'd say we should also add a comment to explain why the test can't be run in parallel. I'm happy to make the update @smaeda-ks if you'd like?

@smaeda-ks smaeda-ks changed the title use alias for no_auth data source to avoid race conditions don't use ParallelTest for no_auth data source Jul 22, 2021
@Integralist Integralist merged commit 701de62 into fastly:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants