-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump go-fastly version #467
bump go-fastly version #467
Conversation
df6cad2
to
c9e81d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one minor nitpicky comment but otherwise 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
switch snippetType { | ||
case "init": | ||
opts.Type = gofastly.SnippetTypeInit | ||
case "recv": | ||
opts.Type = gofastly.SnippetTypeRecv | ||
case "hash": | ||
opts.Type = gofastly.SnippetTypeHash | ||
case "hit": | ||
opts.Type = gofastly.SnippetTypeHit | ||
case "miss": | ||
opts.Type = gofastly.SnippetTypeMiss | ||
case "pass": | ||
opts.Type = gofastly.SnippetTypePass | ||
case "fetch": | ||
opts.Type = gofastly.SnippetTypeFetch | ||
case "error": | ||
opts.Type = gofastly.SnippetTypeError | ||
case "deliver": | ||
opts.Type = gofastly.SnippetTypeDeliver | ||
case "log": | ||
opts.Type = gofastly.SnippetTypeLog | ||
case "none": | ||
opts.Type = gofastly.SnippetTypeNone | ||
} | ||
opts.Type = gofastly.SnippetType(snippetType) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🙂
Full test passed.