Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-fastly version #467

Merged
merged 12 commits into from
Sep 14, 2021

Conversation

smaeda-ks
Copy link
Contributor

@smaeda-ks smaeda-ks commented Sep 5, 2021

Full test passed.

@smaeda-ks smaeda-ks self-assigned this Sep 9, 2021
@smaeda-ks smaeda-ks added enhancement New feature or request bug labels Sep 9, 2021
@smaeda-ks smaeda-ks marked this pull request as ready for review September 9, 2021 03:47
@smaeda-ks smaeda-ks changed the title [WIP] bump go-fastly version bump go-fastly version Sep 9, 2021
Copy link
Contributor

@bengesoff bengesoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor nitpicky comment but otherwise 👍🏼

fastly/resource_fastly_service_acl_entries_v1.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines -160 to +157
switch snippetType {
case "init":
opts.Type = gofastly.SnippetTypeInit
case "recv":
opts.Type = gofastly.SnippetTypeRecv
case "hash":
opts.Type = gofastly.SnippetTypeHash
case "hit":
opts.Type = gofastly.SnippetTypeHit
case "miss":
opts.Type = gofastly.SnippetTypeMiss
case "pass":
opts.Type = gofastly.SnippetTypePass
case "fetch":
opts.Type = gofastly.SnippetTypeFetch
case "error":
opts.Type = gofastly.SnippetTypeError
case "deliver":
opts.Type = gofastly.SnippetTypeDeliver
case "log":
opts.Type = gofastly.SnippetTypeLog
case "none":
opts.Type = gofastly.SnippetTypeNone
}
opts.Type = gofastly.SnippetType(snippetType)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙂

@Integralist Integralist merged commit 5ee4437 into fastly:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants