Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore 404 on GetPackage when importing wasm service #487

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Ignore 404 on GetPackage when importing wasm service #487

merged 3 commits into from
Oct 19, 2021

Conversation

smaeda-ks
Copy link
Contributor

No description provided.

@smaeda-ks smaeda-ks added the bug label Oct 12, 2021
@smaeda-ks smaeda-ks self-assigned this Oct 12, 2021
@smaeda-ks
Copy link
Contributor Author

@bengesoff This is a low priority, but would like to have your thoughts on this.
Basically, if a user creates a wasm service in the Fastly UI with no package added (e.g., has no active version yet) and try to import this service, GetPackage will report 404 and results in error.

@smaeda-ks smaeda-ks marked this pull request as ready for review October 15, 2021 20:54
bengesoff
bengesoff approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@bengesoff bengesoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the latest change works as expected, LGTM 👍🏼

@smaeda-ks smaeda-ks merged commit 1f8aed2 into fastly:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist left review comments

@bengesoff bengesoff bengesoff approved these changes

Assignees

@smaeda-ks smaeda-ks

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smaeda-ks @Integralist @bengesoff