Do not send 0 subnet value unless explicitly set
#496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengesoff
reviewed
Nov 3, 2021
|
|
||
| subnet := convertSubnetToInt(v["subnet"].(string)) | ||
| // only set zero subnet if the attribute is explicitly set | ||
| if v["subnet"].(string) == "0" || subnet != 0 { |
There was a problem hiding this comment.
Do you think it might be cleaner to move this logic inside convertSubnetToInt? Then convertSubnetToInt could return *int
There was a problem hiding this comment.
I think I'm okay with the current
|
Looks like some of the implementation needs fixing but the principle seems reasonable! |
|
@bengesoff @Integralist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we changed the
subnettype toint:fastly/go-fastly#288
and updated go-fastly version:
https://github.com/fastly/terraform-provider-fastly/blob/main/CHANGELOG.md#0350-september-15-2021
We started sending
0subnet value even if the value is not set. This is becauseconvertSubnetToIntreturns the default value (0) when passing an empty string (""). Fixing this to only send 0 value when thesubnetattribute is explicitly set by the user.Also,
flattenAclEntriesfunction needs to know if the returnedsubnetvalue isnullor anyintvalue in order to track them properly in the state file. To do so, we need to make a change in the upstream go-fastly package:fastly/go-fastly#316
Otherwise, we always see
0subnet value regardless of the actual returned value (i.e.,nullvs0int value) and save it to the state file, which causes a diff loop.