Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new modsec_rule_ids filter argument in fastly_waf_rules data resource #521

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Add new modsec_rule_ids filter argument in fastly_waf_rules data resource #521

merged 4 commits into from
Jan 10, 2022

Conversation

smaeda-ks
Copy link
Contributor

@smaeda-ks smaeda-ks commented Jan 4, 2022 •
edited
Loading

Address: #520

Relevant go-fastly PR: fastly/go-fastly#322

@smaeda-ks smaeda-ks self-assigned this Jan 4, 2022
@smaeda-ks smaeda-ks added the enhancement New feature or request label Jan 4, 2022
@smaeda-ks smaeda-ks linked an issue Jan 4, 2022 that may be closed by this pull request
feat: fastly_waf_rules data_source should support retrieving id #520
Closed
@smaeda-ks smaeda-ks requested a review from Integralist January 10, 2022 12:18
@smaeda-ks smaeda-ks marked this pull request as ready for review January 10, 2022 12:19
@Integralist Integralist merged commit a5b9269 into main Jan 10, 2022
@Integralist Integralist deleted the shohei-update-waf-rules-data-source branch January 10, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees

@smaeda-ks smaeda-ks

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: fastly_waf_rules data_source should support retrieving id
2 participants
@smaeda-ks @Integralist