Changes for v1.0.0 #532
Merged
Changes for v1.0.0 #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add DiffSuppressFunc to optionally suppress all diffs on ACL entries Adds a manage_entries attribute which defaults to false. Then a DiffSuppressFunc reads this and decides whether to suppress the diff on the entries set. By default this then only applies the changes on create and does nothing the rest of the time, unless the user sets manage_entries to true manually, then it behaves as usual. This is to make the resource safer by default in the event that entries are added to the ACL outside of Terraform, so that they aren't accidentally deleted. * Add acceptance tests for manage_entries attribute * Add DiffSuppressFunc manage_entries to dictionary items as well Same change as for the ACL entries resource, but for the dictionary items. * Run make generate-docs * add a missing argument * re-generate docs Co-authored-by: Ben Gesoff <[email protected]> Co-authored-by: Hieu Doan <[email protected]>
The Fastly web interface defaults "Auto load balance" to "No". The most common reason for having multiple backends in a single service is to route different paths to different backends, rather than load balance between different origins. Currently, this provider defaults `auto_loadbalance` to true, which is surprising and confusing. This commit makes `auto_loadbalance` default to false to reduce confusion. Co-authored-by: Ben Gesoff <[email protected]> Co-authored-by: Hieu Doan <[email protected]>
* Update default values for format & format_version * Update format & format_version in docs and doc strings * Cosmetic change: capitilise Default * Update format & format_version in tests * Fix 'format' for papertail * add FormatVersion for the GCS struct * update gcslogging doc with format_version * change double quotes to backticks Co-authored-by: Hieu Doan <[email protected]>
* Change the email field to user to align with the API docs. * fix TestGcsloggingEnvDefaultFuncAttributes by using the user attribute * fix TestResourceFastlyFlattenGCS * go fmt Co-authored-by: Hieu Doan <[email protected]>
Co-authored-by: Shohei Maeda <[email protected]> Co-authored-by: Hieu Doan <[email protected]>
Consistent resource naming: - change `v1` to `vcl` - remove `v1` - add `logging` prefix - update docs and examples Other changes: - fix acl manage entries test - fix `user` attribute in gcs Co-authored-by: Hieu Doan <[email protected]>
Integralist
added a commit
that referenced
this pull request
Feb 8, 2022
* Changes for v1.0.0 (#532) * V1 versionless deletion protection (#110) * Add DiffSuppressFunc to optionally suppress all diffs on ACL entries Adds a manage_entries attribute which defaults to false. Then a DiffSuppressFunc reads this and decides whether to suppress the diff on the entries set. By default this then only applies the changes on create and does nothing the rest of the time, unless the user sets manage_entries to true manually, then it behaves as usual. This is to make the resource safer by default in the event that entries are added to the ACL outside of Terraform, so that they aren't accidentally deleted. * Add acceptance tests for manage_entries attribute * Add DiffSuppressFunc manage_entries to dictionary items as well Same change as for the ACL entries resource, but for the dictionary items. * Run make generate-docs * add a missing argument * re-generate docs Co-authored-by: Ben Gesoff <[email protected]> Co-authored-by: Hieu Doan <[email protected]> * Make backend `auto_loadbalance` default to false (#111) The Fastly web interface defaults "Auto load balance" to "No". The most common reason for having multiple backends in a single service is to route different paths to different backends, rather than load balance between different origins. Currently, this provider defaults `auto_loadbalance` to true, which is surprising and confusing. This commit makes `auto_loadbalance` default to false to reduce confusion. Co-authored-by: Ben Gesoff <[email protected]> Co-authored-by: Hieu Doan <[email protected]> * V1 update default format and format version (#112) * Update default values for format & format_version * Update format & format_version in docs and doc strings * Cosmetic change: capitilise Default * Update format & format_version in tests * Fix 'format' for papertail * add FormatVersion for the GCS struct * update gcslogging doc with format_version * change double quotes to backticks Co-authored-by: Hieu Doan <[email protected]> * V1 change email to user in gcslogging (#113) * Change the email field to user to align with the API docs. * fix TestGcsloggingEnvDefaultFuncAttributes by using the user attribute * fix TestResourceFastlyFlattenGCS * go fmt Co-authored-by: Hieu Doan <[email protected]> * use `TypeList` schema for `gzip` nested block attributes (#114) Co-authored-by: Shohei Maeda <[email protected]> Co-authored-by: Hieu Doan <[email protected]> * Consistent resource naming (#115) Consistent resource naming: - change `v1` to `vcl` - remove `v1` - add `logging` prefix - update docs and examples Other changes: - fix acl manage entries test - fix `user` attribute in gcs Co-authored-by: Hieu Doan <[email protected]> Co-authored-by: Ben Gesoff <[email protected]> Co-authored-by: Hieu Doan <[email protected]> Co-authored-by: Shohei Maeda <[email protected]> * make fmt * fix broken merge * make generate-docs * Remove Director `capacity` field as it's unused (#535) * remove director capacity * Fix the example usage in docs/index.md (#533) * Fix the example usage in docs/index.md * Fix templates/index.md.tmpl * run make generate-docs * Remove extraneous line * Remove extraneous line Co-authored-by: Mark McDonnell <[email protected]> * Support Terraform CLI 1.1.4 (#536) * fix director tests * update docs Co-authored-by: Hiromasa Kakehashi <[email protected]> * Add missing docs and attributes in versionless resources (#537) * add the 'manage_snippets' attribute into 'fastly_service_dynamic_snippet_content' update 'fastly_service_dictionary_items' * delete a typo in manage_snippets * domestic change: format hcl in the test * Remove 'ignore_changes' from the docs and examples Co-authored-by: Hieu Doan <[email protected]> * Bump terraform-plugin-sdk (#538) * remove terraform json from go.mod * format example * regenerate docs after typo Co-authored-by: Hiieu <[email protected]> Co-authored-by: Ben Gesoff <[email protected]> Co-authored-by: Hieu Doan <[email protected]> Co-authored-by: Shohei Maeda <[email protected]> Co-authored-by: Hiromasa Kakehashi <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes: