Make backends not required on compute@edge resource #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested changes
Apr 22, 2022
There was a problem hiding this comment.
👋🏻 Thanks for opening this PR (and your patience waiting for feedback).
The changes look good to me.
I've pulled your branch locally and validated the changes manually (all works as expected).
I've also run the complete integration test suite, which passes as well.
I have only one change request, which is to update the example examples/resources/service_compute_basic_usage.tf to remove the backend block and to regenerate the docs by running make generate-docs.
Thanks!
|
I updated the example file and regenerated the doc |
|
Let me know if anything else is required for this @Integralist |
Integralist
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the compute@edge resource requires at least one backend to create the resource however this is actually not required of compute@edge services. Aligning the terraform resource with the compute@edge service.