Handle deletion of already deleted or never created resources #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run updateInvalidBackend -timeout 120m
? github.com/terraform-providers/terraform-provider-fastly [no test files]
=== RUN TestAccFastlyServiceV1_updateInvalidBackend
--- FAIL: TestAccFastlyServiceV1_updateInvalidBackend (3.12s)
testing.go:434: Step 1 error: Error applying: 1 error(s) occurred:
* fastly_service_v1.foo: 1 error(s) occurred:
* fastly_service_v1.foo: 404 - Not Found:
Title: Record not found
Detail: Couldn't find Backend '{ version => 1, name => tf -test backend, deleted => 0000-00-00 00:00:00, service => 8qUQLdspTiy27v2fmabKZ }'
FAIL
FAIL github.com/terraform-providers/terraform-provider-fastly/fastly 3.137s
```
Support seamless recovery from an invalid domain name. This is made difficult due to the lack of domain tracking as an independent resource. Otherwise, we could detect the presence of a domain ID that would be set after successful creation.
Receiving a 404 when deleting a resource is a success condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect a not found response with the resource deletion conditions and consider a not found response a success condition.