Typo fix #915
Closed
Typo fix #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested changes
Jan 16, 2025
| @@ -22,7 +22,7 @@ The examples below demonstrate usage with AWS Route53 to configure DNS, and the | |||
|
|
|||
| **Basic usage:** | |||
|
|
|||
| The following example demonstrates how to configured two subdomains (e.g. `a.example.com`, `b.example.com`). | |||
There was a problem hiding this comment.
👋🏻
Thanks for taking the time to correct this typo.
This file is the "generated" documentation file, and so you actually need to edit:
https://github.com/fastly/terraform-provider-fastly/blob/main/templates/resources/tls_subscription.md.tmpl#L25
Then run make generate-docs to generate this .md file.
But I guess as you've already manually edited this generated file you might as well just make the same edit to the template file and then there's no need to run that Makefile target 🙂
|
Closing this, per the comment above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.