Fix coloring on cygwin/msys2 shell #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mattn |
|
|
k-takata
reviewed
Feb 17, 2017
color.go
Outdated
| @@ -18,8 +18,7 @@ var ( | |||
| // or not. This is a global option and affects all colors. For more control | |||
| // over each color block use the methods DisableColor() individually. | |||
| NoColor = os.Getenv("TERM") == "dumb" || | |||
| !isatty.IsTerminal(os.Stdout.Fd()) || | |||
| !isatty.IsCygwinTerminal(os.Stdout.Fd()) | |||
| (!isatty.IsTerminal(os.Stdout.Fd()) || !isatty.IsCygwinTerminal(os.Stdout.Fd())) | |||
There was a problem hiding this comment.
Still wrong, I think.
If both IsTerminal() and IsCygwinTerminal() return false, color cannot be used.
At least one of them returns true, color can be used.
There was a problem hiding this comment.
Previously it was like:
NoColor = os.Getenv("TERM") == "dumb" ||
!isatty.IsTerminal(os.Stdout.Fd()) ||
!isatty.IsCygwinTerminal(os.Stdout.Fd())Do you say it should be like this?
NoColor = os.Getenv("TERM") == "dumb" ||
!isatty.IsTerminal(os.Stdout.Fd()) ||
isatty.IsCygwinTerminal(os.Stdout.Fd())I'm really confused right now. I don't have a way to test it, so can you test and give me the correct answer maybe?
There was a problem hiding this comment.
I meant:
NoColor = os.Getenv("TERM") == "dumb" ||
!(isatty.IsTerminal(os.Stdout.Fd()) ||
isatty.IsCygwinTerminal(os.Stdout.Fd()))This is equivalent with @mattn's suggestion.
|
LGTM |
|
Thanks @mattn , rebased and merging once it's green |
color.Green("YAY") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57