Implements: Early stopping support for single and batch trials in Ax (#98) #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there were two interfaces in the `OptimizationProblem` for calling evaluation functions (e.g. objectives): one for evaluating individuals, and one for populations. To simplify the code base, these two methods were now unified. To ensure backward compatibility, a 1D-Array is returned if a single individual is passed to the function.
Co-authored-by: r.jaepel <[email protected]>
Previously, the cadet path set in Cadet(install_path="path") was not inherited into cadet instances created from the run() method.
Fix and extend tests about .calculate_interstitial_rt/velocity
Previously, this was required because CADET-Core was not setting the PATH correctly. Now, this can lead to inconsistent behaviour. Note, this requires CADET>4.4.0
Recently, the option to (not) plot the time axis using minutes was introduced. This commit fixes some methods that were not properly implemented. Moreover, the name of the flag was changed from `use_minutes` to `x_axis_in_minutes` to make clear that only plotting is affected and not other parameter values (e.g. start and end times).
Co-authored-by: daklauss <[email protected]>
Updates and Fixes plot_at_position by adding start, end and x_axis_in_minutes as parameters in solution.py
The error was caused by lower floating point division in the numba.njit optimized code. We now check if r_x_den * r_y_den is != zero and only then calculate the real result.
Clean up results and tmp directories after running tests.
flo-schu
changed the title
flo-schu
changed the title
schmoelder
force-pushed
the
dev
branch
11 times, most recently
from
35e0c67 to
d97cf31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements early stopping support for Ax.
Implementation tasks:
When this is implemented, a PR can be opened from https://github.com/flo-schu/Ax/tree/0.3.5 before this, the fork has to be migrated to the most recent version of Ax.