Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add function optimizer.load_results() to load OptimizationResults #228

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ronald-jaepel
Copy link
Collaborator

Add function optimizer.load_results() to load and return OptimizationResults based on a checkpoint.h5 or final.h5

@ronald-jaepel ronald-jaepel force-pushed the feature/load_optim_results_from_checkpoint branch from a54b636 to a5cf994 Compare February 19, 2025 09:53
@ronald-jaepel
Copy link
Collaborator Author

Tests complete locally but fail on the CI with the same error message as other CI tests:


=========================== short test summary info ============================
FAILED tests/test_cache.py::TestCache::test_delete - sqlite3.OperationalError: no such column: "size" - should this be a string literal in single-quotes?
FAILED tests/test_cache.py::TestCache::test_delete_database - sqlite3.OperationalError: no such column: "size" - should this be a string literal in single-quotes?
FAILED tests/test_cache.py::TestCache::test_get - sqlite3.OperationalError: no such column: "size" - should this be a string literal in single-quotes?
FAILED tests/test_cache.py::TestCache::test_prune - sqlite3.OperationalError: no such column: "size" - should this be a string literal in single-quotes?
FAILED tests/test_cache.py::TestCache::test_set - sqlite3.OperationalError: no such column: "size" - should this be a string literal in single-quotes?
FAILED tests/test_cache.py::TestCache::test_tags - sqlite3.OperationalError: no such column: "size" - should this be a string literal in single-quotes?
FAILED tests/test_optimization_integration.py::TestBatchElutionOptimizationSingleObjective::test_single_core - sqlite3.OperationalError: no such column: "size" - should this be a string literal in single-quotes?
FAILED tests/test_parallelization_adapter.py::TestOptimizerParallelizationBackend::test_parallel_optimization - sqlite3.OperationalError: no such column: "size" - should this be a string literal in single-quotes?

…Results based on a `checkpoint.h5` or `final.h5`
Fix tests by patching the removal of None values from OptimizationResults to allow HDF5 serialization with any CADET-Python version
@schmoelder schmoelder force-pushed the feature/load_optim_results_from_checkpoint branch from a5cf994 to 87d2666 Compare March 10, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Loading of previously generated optimization results
2 participants