Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping version to 0.2.2rc6 #45

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Bumping version to 0.2.2rc6 #45

merged 2 commits into from
Nov 24, 2020

Conversation

patkivikram
Copy link
Collaborator

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Please describe your pull request.

NOTE: All patches should be made against master, not a maintenance branch like
3.1, 2.5, etc. That is unless the bug is already fixed in master, but not in
that version series.

If it fixes a bug or resolves a feature request,
be sure to link to that issue via (Fixes #4412) for example.

@patkivikram
Copy link
Collaborator Author

patkivikram commented Nov 24, 2020

The enhanced put method fails the recovery as it does not account for standby's and also does not resume recovery on_buffer_drop. This needs to be implemented to ensure full support for it- we can put it in our backlog for now

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #45 (dce1331) into master (2f81086) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   64.04%   64.04%           
=======================================
  Files          99       99           
  Lines       10287    10287           
  Branches     1156     1156           
=======================================
  Hits         6588     6588           
  Misses       3545     3545           
  Partials      154      154           
Impacted Files Coverage Δ
faust/transport/conductor.py 72.34% <ø> (ø)
faust/transport/consumer.py 40.18% <0.00%> (ø)
faust/transport/drivers/aiokafka.py 33.33% <0.00%> (ø)
faust/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f81086...dce1331. Read the comment docs.

@patkivikram
Copy link
Collaborator Author

fixes 37

@patkivikram
Copy link
Collaborator Author

Also fixes 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants