Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "sideEffects: false" to package.json #474

Merged
merged 1 commit into from
May 25, 2020
Merged

Conversation

ericjeney
Copy link
Contributor

This PR marks htmlparser2 as free of side effects to allow Webpack to tree shake it if possible. I read through all of the code in this package and didn't spot any side effects, so I think this should be safe.

For more info:
https://webpack.js.org/guides/tree-shaking/
https://developers.google.com/web/fundamentals/performance/optimizing-javascript/tree-shaking

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.552% when pulling aa7375d on ericjeney:patch-1 into a68dfba on fb55:master.

@ericjeney
Copy link
Contributor Author

@fb55 fb55 merged commit d90dd64 into fb55:master May 25, 2020
@fb55
Copy link
Owner

fb55 commented May 25, 2020

Thanks a lot @ericjeney, for this, as well as all the other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants