Coverage

[brettz9]

Some improvements for (else branch) coverage, bringing two files up to full 100% coverage. Also fixes a linting warning.

• feedhandler: overcome lint warning
• test(WritableStream): cover else branch
• test(Parser): cover (open-implies-close case of) onclosetag else branch with non-br void close tag in non-XML mode
• refactor: improve else coverage by avoiding openImpliesClose optional chaining operator (check for existence already made upon entering block)
• refactor: improve coverage by avoiding null check for endIndex (since by calling _updatePosition, it will never be null). Cast endIndex as number to avoid TS believing it could be null.

[coveralls]

Coverage remained the same at 98.601% when pulling 75f563e on brettz9:coverage into ea6ceb0 on fb55:master.

[brettz9]

The coverage percent decrease is apparently due to my having eliminated the need for two previously covered lines (while having increased coverage elsewhere only for else branches). So this is actually an improvement in coverage with no true coverage regression.

[fb55]

Some great changes. I'd love to see a test case actually check its outputs, but then we should be good to go here!

[fb55]

Hi @brettz9, made the change mentioned above & merged the PR. Thank you for this (as well as #543), great way to contribute to a project.

[brettz9]

Thank you! Apologies I couldn't carry it through myself--great if it may help however slightly to your great project! :-)