fix(tokenizer): Parse entities in <title> tags #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beat you to it, hope that's alright! @billneff79 @cheeseandcereal Would love a review if you guys have a moment. |
| "data": ["the \"title\""] | ||
| }, | ||
| { | ||
| "event": "closetag", |
There was a problem hiding this comment.
is this event actually fired? I don't see a </title> in the html string for this fixture
There was a problem hiding this comment.
The parser will close all currently open tags at the end of the input.
cheeseandcereal
approved these changes
Oct 20, 2020
|
Thanks a lot @cheeseandcereal! |
Awesome! Thanks @fb55 . My only thought is that it would be tidy and safe to have one more unit test to verify that title does not decode entities when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592.