Add support for proxies #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbradyirl
reviewed
Mar 12, 2024
mochipon
force-pushed
the
feat/proxy_support
branch
from
75be641 to
16f1b77
Compare
mochipon
force-pushed
the
feat/proxy_support
branch
2 times, most recently
from
96a2ada to
6a00b13
Compare
|
@fbradyirl Sorry for bothering you due to git mis-operation. This PR is ready for merge, thank you. |
|
Superseded by #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it possible to use the
webex_botin a proxy environment. As support for proxies inwebsocketshas been stucked for over five years (ref. python-websockets/websockets#364), I've decided to introduce thewebsockets_proxylibrary as a drop-in replacement.The additional library is not necessary for those who do not require a proxy, so it might be better to offer this feature as an optional. To support proxies, you will need to explicitly include the
[proxy]option when installing.fixes #35 #39