Skip to content

Commit

Permalink
revert entity columns
Browse files Browse the repository at this point in the history
Signed-off-by: Oleksii Moskalenko <[email protected]>
  • Loading branch information
pyalex committed May 11, 2022
1 parent 33ea973 commit 0190b34
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
8 changes: 5 additions & 3 deletions sdk/python/feast/feature_logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
FeatureViewNotFoundException,
OnDemandFeatureViewNotFoundException,
)
from feast.feature_view import DUMMY_ENTITY_ID
from feast.feature_view import DUMMY_ENTITY_NAME
from feast.protos.feast.core.FeatureService_pb2 import (
LoggingConfig as LoggingConfigProto,
)
Expand Down Expand Up @@ -77,10 +77,12 @@ def get_schema(self, registry: "Registry") -> pa.Schema:
fields[field.name] = FEAST_TYPE_TO_ARROW_TYPE[field.dtype]

else:
for entity_column in feature_view.entity_columns:
if entity_column.name == DUMMY_ENTITY_ID:
for entity_name in feature_view.entities:
if entity_name == DUMMY_ENTITY_NAME:
continue

entity = registry.get_entity(entity_name, self._project)

join_key = projection.join_key_map.get(
entity.join_key, entity.join_key
)
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/feature_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ def __copy__(self):
online=self.online,
)
fv.projection = copy.copy(self.projection)
fv.entities = self.entities
return fv

def __eq__(self, other):
Expand Down
2 changes: 0 additions & 2 deletions sdk/python/tests/integration/e2e/test_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
)
from feast.protos.feast.serving.ServingService_pb2 import FieldStatus
from feast.wait import wait_retry_backoff

from tests.integration.feature_repos.repo_configuration import (
construct_universal_feature_views,
)
Expand All @@ -27,7 +26,6 @@
)
from tests.utils.logged_features import prepare_logs


_features = [
"customer_profile:current_balance",
"customer_profile:avg_passenger_count",
Expand Down

0 comments on commit 0190b34

Please sign in to comment.