Skip to content

Commit

Permalink
Generic error class
Browse files Browse the repository at this point in the history
Signed-off-by: Achal Shah <[email protected]>
  • Loading branch information
achals committed Jun 21, 2021
1 parent ec876d6 commit 2030e47
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions sdk/python/feast/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ def __init__(self, online_store_class_name: str):


class FeastStoreConfigInvalidName(Exception):
def __init__(self, online_store_config_class_name: str, store_type="Online"):
def __init__(self, store_config_class_name: str, store_type: str):
super().__init__(
f"Online Store Config Class '{online_store_config_class_name}' "
f"Config Class '{store_config_class_name}' "
f"should end with the string `{store_type}Config`.'"
)

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/repo_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def get_config_class_from_type(
module_name: str, config_class_name: str, store_type: str
):
if not config_class_name.endswith(f"{store_type}Config"):
raise errors.FeastStoreConfigInvalidName(config_class_name)
raise errors.FeastStoreConfigInvalidName(config_class_name, store_type)

# Try importing the module that contains the custom provider
try:
Expand Down

0 comments on commit 2030e47

Please sign in to comment.