Fix get_online_features telemetry to only log every 10000 times (#1786)

* Fix get_online_features telemetry to only log every 10000 times Signed-off-by: Felix Wang <[email protected]> * Avoid int overflow Signed-off-by: Felix Wang <[email protected]> * Log telemetry on second but not first call Signed-off-by: Felix Wang <[email protected]>
feast-dev · Aug 18, 2021 · 7ef5a41 · 7ef5a41
1 parent da436b5
commit 7ef5a41
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/sdk/python/feast/usage.py b/sdk/python/feast/usage.py
@@ -77,10 +77,10 @@ def log(self, function_name: str):
         self.check_env_and_configure()
         if self._usage_enabled and self.usage_id:
             if function_name == "get_online_features":
-                if self._usage_counter["get_online_features"] % 10000 != 0:
-                    self._usage_counter["get_online_features"] += 1
+                self._usage_counter["get_online_features"] += 1
+                if self._usage_counter["get_online_features"] % 10000 != 2:
                     return
-
+                self._usage_counter["get_online_features"] = 2  # avoid overflow
             json = {
                 "function_name": function_name,
                 "telemetry_id": self.usage_id,