Skip to content

Commit

Permalink
Fix typo
Browse files Browse the repository at this point in the history
Signed-off-by: Matt Delacour <[email protected]>
  • Loading branch information
Matt Delacour committed Jun 29, 2021
1 parent 61a51e7 commit 90e5fa9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sdk/python/feast/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def __init__(self, repo_obj_type: str, specific_issue: str):

class BigQueryJobCancelled(Exception):
def __init__(self, job_id):
super().__init__(f"The following job '{job_id}' got cancelled")
super().__init__(f"The BigQuery job with ID '{job_id}' was cancelled")


class RedshiftCredentialsError(Exception):
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/offline_stores/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,11 +280,11 @@ def _is_done(job_id):
return client.get_job(job_id).state in ["PENDING", "RUNNING"]

@retry(wait=wait_fixed(10), stop=stop_after_delay(1800), reraise=True)
def _wait_till_done(job_id):
def _wait_until_done(job_id):
return _is_done(job_id)

job_id = bq_job.job_id
_wait_till_done(job_id=job_id)
_wait_until_done(job_id=job_id)

if not _is_done(job_id):
client.cancel_job(job_id)
Expand Down

0 comments on commit 90e5fa9

Please sign in to comment.