Skip to content

Commit

Permalink
Clean up code
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Zhang <[email protected]>
  • Loading branch information
kevjumba committed Mar 2, 2022
1 parent e5fedcc commit a321d54
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/pr_integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,6 @@ jobs:
# code from the PR.
ref: refs/pull/${{ github.event.pull_request.number }}/merge
submodules: recursive
- name: Start Redis
uses: supercharge/[email protected]
with:
redis-version: ${{ matrix.redis-version }}
redis-port: 12345
- name: Setup Python
uses: actions/setup-python@v2
id: setup-python
Expand Down Expand Up @@ -150,10 +145,6 @@ jobs:
run: pip install pip-tools
- name: Install dependencies
run: make install-python-ci-dependencies
- name: Setup Redis Cluster
run: |
docker pull vishnunair/docker-redis-cluster:latest
docker run -d -p 6001:6379 -p 6002:6380 -p 6003:6381 -p 6004:6382 -p 6005:6383 -p 6006:6384 --name redis-cluster vishnunair/docker-redis-cluster
- name: Test python
if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak
env:
Expand All @@ -174,4 +165,4 @@ jobs:
flags: integrationtests
env_vars: OS,PYTHON
fail_ci_if_error: true
verbose: true
verbose: true
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"type": "redis",
"redis_type": "redis_cluster",
# Redis Cluster Port Forwarding is setup in "pr_integration_tests.yaml" under "Setup Redis Cluster".
"connection_string": "127.0.0.1:7001,127.0.0.1:7002,127.0.0.1:7003",
"connection_string": "127.0.0.1:6001,127.0.0.1:6002,127.0.0.1:6003",
}

# FULL_REPO_CONFIGS contains the repo configurations (e.g. provider, offline store,
Expand Down

0 comments on commit a321d54

Please sign in to comment.