fix: Remove ci extra from the feature transformation server dockerfile (

#2618) * fix: Remove ci extra from the feature transformation server dockerfile and pin numpy for py3.7 support Signed-off-by: Achal Shah <[email protected]> * remove debug Signed-off-by: Achal Shah <[email protected]> * pin requirements Signed-off-by: Achal Shah <[email protected]>
feast-dev · Apr 28, 2022 · a7437fa · a7437fa
1 parent 40962fc
commit a7437fa
Show file tree

Hide file tree

Showing 12 changed files with 44 additions and 621 deletions.
diff --git a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
diff --git a/sdk/python/feast/infra/transformation_servers/Dockerfile b/sdk/python/feast/infra/transformation_servers/Dockerfile
@@ -9,7 +9,7 @@ COPY protos protos
 COPY README.md README.md
 
 # Install dependencies
-RUN pip3 install -e 'sdk/python[ci]'
+RUN pip3 install -e 'sdk/python'
 
 # Start feature transformation server
 CMD [ "python", "app.py" ]
diff --git a/sdk/python/requirements/py3.10-ci-requirements.txt b/sdk/python/requirements/py3.10-ci-requirements.txt
@@ -255,6 +255,8 @@ grpcio-tools==1.44.0
     # via feast (setup.py)
 h11==0.13.0
     # via uvicorn
+happybase==1.2.0
+    # via feast (setup.py)
 hiredis==2.0.0
     # via feast (setup.py)
 httplib2==0.20.4
@@ -356,9 +358,10 @@ nbformat==5.3.0
     # via great-expectations
 nodeenv==1.6.0
     # via pre-commit
-numpy==1.22.3
+numpy==1.21.6
     # via
     #   altair
+    #   feast (setup.py)
     #   great-expectations
     #   pandas
     #   pandavro
@@ -407,6 +410,8 @@ platformdirs==2.5.1
     # via virtualenv
 pluggy==1.0.0
     # via pytest
+ply==3.11
+    # via thriftpy2
 portalocker==2.4.0
     # via msal-extensions
 pre-commit==2.18.1
@@ -594,6 +599,7 @@ six==1.16.0
     #   google-cloud-core
     #   google-resumable-media
     #   grpcio
+    #   happybase
     #   mock
     #   msrestazure
     #   pandavro
@@ -638,6 +644,8 @@ termcolor==1.1.0
     # via great-expectations
 testcontainers==3.5.3
     # via feast (setup.py)
+thriftpy2==0.4.14
+    # via happybase
 toml==0.10.2
     # via
     #   black

diff --git a/sdk/python/requirements/py3.10-requirements.txt b/sdk/python/requirements/py3.10-requirements.txt
@@ -73,8 +73,9 @@ markupsafe==2.1.1
     # via jinja2
 mmh3==3.0.0
     # via feast (setup.py)
-numpy==1.22.3
+numpy==1.21.6
     # via
+    #   feast (setup.py)
     #   pandas
     #   pandavro
     #   pyarrow

diff --git a/sdk/python/requirements/py3.7-ci-requirements.txt b/sdk/python/requirements/py3.7-ci-requirements.txt
@@ -265,6 +265,8 @@ grpcio-tools==1.44.0
     # via feast (setup.py)
 h11==0.13.0
     # via uvicorn
+happybase==1.2.0
+    # via feast (setup.py)
 hiredis==2.0.0
     # via feast (setup.py)
 httplib2==0.20.4
@@ -430,6 +432,7 @@ notebook==6.4.10
 numpy==1.21.5
     # via
     #   altair
+    #   feast (setup.py)
     #   great-expectations
     #   pandas
     #   pandavro
@@ -481,6 +484,8 @@ platformdirs==2.5.1
     # via virtualenv
 pluggy==1.0.0
     # via pytest
+ply==3.11
+    # via thriftpy2
 portalocker==2.4.0
     # via msal-extensions
 pre-commit==2.17.0
@@ -682,7 +687,7 @@ six==1.16.0
     #   google-cloud-core
     #   google-resumable-media
     #   grpcio
-    #   isodate
+    #   happybase
     #   mock
     #   msrestazure
     #   pandavro
@@ -727,8 +732,8 @@ terminado==0.13.2
     # via notebook
 testcontainers==3.5.3
     # via feast (setup.py)
-testpath==0.6.0
-    # via nbconvert
+thriftpy2==0.4.14
+    # via happybase
 toml==0.10.2
     # via
     #   black

diff --git a/sdk/python/requirements/py3.7-requirements.txt b/sdk/python/requirements/py3.7-requirements.txt
@@ -79,6 +79,7 @@ mmh3==3.0.0
     # via feast (setup.py)
 numpy==1.21.5
     # via
+    #   feast (setup.py)
     #   pandas
     #   pandavro
     #   pyarrow

diff --git a/sdk/python/requirements/py3.8-ci-requirements.txt b/sdk/python/requirements/py3.8-ci-requirements.txt
@@ -259,6 +259,8 @@ grpcio-tools==1.44.0
     # via feast (setup.py)
 h11==0.13.0
     # via uvicorn
+happybase==1.2.0
+    # via feast (setup.py)
 hiredis==2.0.0
     # via feast (setup.py)
 httplib2==0.20.4
@@ -362,9 +364,10 @@ nbformat==5.3.0
     # via great-expectations
 nodeenv==1.6.0
     # via pre-commit
-numpy==1.22.3
+numpy==1.21.6
     # via
     #   altair
+    #   feast (setup.py)
     #   great-expectations
     #   pandas
     #   pandavro
@@ -413,6 +416,8 @@ platformdirs==2.5.1
     # via virtualenv
 pluggy==1.0.0
     # via pytest
+ply==3.11
+    # via thriftpy2
 portalocker==2.4.0
     # via msal-extensions
 pre-commit==2.18.1
@@ -602,6 +607,7 @@ six==1.16.0
     #   google-cloud-core
     #   google-resumable-media
     #   grpcio
+    #   happybase
     #   mock
     #   msrestazure
     #   pandavro
@@ -646,6 +652,8 @@ termcolor==1.1.0
     # via great-expectations
 testcontainers==3.5.3
     # via feast (setup.py)
+thriftpy2==0.4.14
+    # via happybase
 toml==0.10.2
     # via
     #   black

diff --git a/sdk/python/requirements/py3.8-requirements.txt b/sdk/python/requirements/py3.8-requirements.txt
@@ -75,8 +75,9 @@ markupsafe==2.1.1
     # via jinja2
 mmh3==3.0.0
     # via feast (setup.py)
-numpy==1.22.3
+numpy==1.21.6
     # via
+    #   feast (setup.py)
     #   pandas
     #   pandavro
     #   pyarrow

diff --git a/sdk/python/requirements/py3.9-ci-requirements.txt b/sdk/python/requirements/py3.9-ci-requirements.txt
@@ -255,6 +255,8 @@ grpcio-tools==1.44.0
     # via feast (setup.py)
 h11==0.13.0
     # via uvicorn
+happybase==1.2.0
+    # via feast (setup.py)
 hiredis==2.0.0
     # via feast (setup.py)
 httplib2==0.20.4
@@ -356,9 +358,10 @@ nbformat==5.3.0
     # via great-expectations
 nodeenv==1.6.0
     # via pre-commit
-numpy==1.22.3
+numpy==1.21.6
     # via
     #   altair
+    #   feast (setup.py)
     #   great-expectations
     #   pandas
     #   pandavro
@@ -407,6 +410,8 @@ platformdirs==2.5.1
     # via virtualenv
 pluggy==1.0.0
     # via pytest
+ply==3.11
+    # via thriftpy2
 portalocker==2.4.0
     # via msal-extensions
 pre-commit==2.18.1
@@ -596,6 +601,7 @@ six==1.16.0
     #   google-cloud-core
     #   google-resumable-media
     #   grpcio
+    #   happybase
     #   mock
     #   msrestazure
     #   pandavro
@@ -640,6 +646,8 @@ termcolor==1.1.0
     # via great-expectations
 testcontainers==3.5.3
     # via feast (setup.py)
+thriftpy2==0.4.14
+    # via happybase
 toml==0.10.2
     # via
     #   black

diff --git a/sdk/python/requirements/py3.9-requirements.txt b/sdk/python/requirements/py3.9-requirements.txt
@@ -73,8 +73,9 @@ markupsafe==2.1.1
     # via jinja2
 mmh3==3.0.0
     # via feast (setup.py)
-numpy==1.22.3
+numpy==1.21.6
     # via
+    #   feast (setup.py)
     #   pandas
     #   pandavro
     #   pyarrow

diff --git a/sdk/python/setup.py b/sdk/python/setup.py
@@ -57,6 +57,7 @@
     "Jinja2>=2.0.0",
     "jsonschema",
     "mmh3",
+    "numpy<1.22",  # 1.22 drops support for python 3.7.
     "pandas>=1.0.0",
     "pandavro==1.5.*",
     "protobuf>=3.10,<3.20",

diff --git a/sdk/python/tests/unit/test_feature_views.py b/sdk/python/tests/unit/test_feature_views.py