fix: Create __init__ files for the proto-generated python dirs (#2410)

* fix: Create __init__ files for the proto-generated python dirs Signed-off-by: Achal Shah <[email protected]> * remove dupe import Signed-off-by: Achal Shah <[email protected]>
feast-dev · Mar 15, 2022 · e17028d · e17028d
1 parent 37ab13b
commit e17028d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -46,7 +46,7 @@ package-protos:
 	cp -r ${ROOT_DIR}/protos ${ROOT_DIR}/sdk/python/feast/protos
 
 compile-protos-python:
-	python setup.py build_python_protos
+	python sdk/python/setup.py build_python_protos
 
 install-python:
 	cd sdk/python && python -m piptools sync requirements/py$(PYTHON)-requirements.txt

diff --git a/sdk/python/setup.py b/sdk/python/setup.py
@@ -215,8 +215,14 @@ def _generate_python_protos(self, path: str):
     def run(self):
         for sub_folder in self.sub_folders:
             self._generate_python_protos(f"feast/{sub_folder}/*.proto")
-
-        from pathlib import Path
+            # We need the __init__ files for each of the generated subdirs
+            # so that they are regular packages, and don't need the `--namespace-packages` flags
+            # when being typechecked using mypy. BUT, we need to exclude `types` because that clashes
+            # with an existing module in the python standard library.
+            if sub_folder == "types":
+                continue
+            with open(f"{self.python_folder}/feast/{sub_folder}/__init__.py", 'w'):
+                pass
 
         for path in Path("feast/protos").rglob("*.py"):
             for folder in self.sub_folders: