fix: Add __eq__, __hash__ to SparkSource for correct comparison (#4028)

* feat: Enable Arrow-based columnar data transfers Signed-off-by: tanlocnguyen <[email protected]> * fix: Add __eq__, __hash__ to SparkSource for comparision Signed-off-by: tanlocnguyen <[email protected]> * chore: simplify the logic Signed-off-by: tanlocnguyen <[email protected]> --------- Signed-off-by: tanlocnguyen <[email protected]> Co-authored-by: tanlocnguyen <[email protected]>
feast-dev · Mar 26, 2024 · e703b40 · e703b40
1 parent 9b98eaf
commit e703b40
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py b/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark_source.py
@@ -185,6 +185,19 @@ def get_table_query_string(self) -> str:
 
         return f"`{tmp_table_name}`"
 
+    def __eq__(self, other):
+        base_eq = super().__eq__(other)
+        if not base_eq:
+            return False
+        return (
+            self.table == other.table
+            and self.query == other.query
+            and self.path == other.path
+        )
+
+    def __hash__(self):
+        return super().__hash__()
+
 
 class SparkOptions:
     allowed_formats = [format.value for format in SparkSourceFormat]