Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parquet ingestion #1410

Merged
merged 5 commits into from
Mar 25, 2021
Merged

Conversation

oavdeev
Copy link
Collaborator

@oavdeev oavdeev commented Mar 25, 2021

What this PR does / why we need it:
Support ingestion from local parquet + add CLI materialize command + e2e test from parquet ingestion to online reads, using that command.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Oleg Avdeev <[email protected]>
@oavdeev
Copy link
Collaborator Author

oavdeev commented Mar 25, 2021

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Mar 25, 2021
@oavdeev
Copy link
Collaborator Author

oavdeev commented Mar 25, 2021

/ok-to-test

oavdeev added 2 commits March 25, 2021 10:31
Signed-off-by: Oleg Avdeev <[email protected]>
Signed-off-by: Oleg Avdeev <[email protected]>
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
Copy link
Member

@woop woop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to have the docstring added at least.

oavdeev added 2 commits March 25, 2021 11:19
Co-authored-by: Willem Pienaar <[email protected]>

Signed-off-by: Oleg Avdeev <[email protected]>
@oavdeev oavdeev force-pushed the materialize-tests branch from 23e070b to 46e817d Compare March 25, 2021 18:20
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Mar 25, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 960f1ed into feast-dev:master Mar 25, 2021
@oavdeev oavdeev deleted the materialize-tests branch March 25, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants