-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python SDK][Auth] Refresh token id w/o gcloud cli #1413
Conversation
Signed-off-by: Oleksii Moskalenko <[email protected]>
So you are able to strip the oid token with the oauth module? I believe I added that code because it didn't work without the gcloud CLI.
It doesnt seem to be a requirement. It's wrapped in a try/except. |
Signed-off-by: Oleksii Moskalenko <[email protected]>
Yes, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Auth: refresh token id w/o gcloud sdk Signed-off-by: Oleksii Moskalenko <[email protected]> * fix unit tests Signed-off-by: Oleksii Moskalenko <[email protected]>
* Auth: refresh token id w/o gcloud sdk Signed-off-by: Oleksii Moskalenko <[email protected]> * fix unit tests Signed-off-by: Oleksii Moskalenko <[email protected]>
Signed-off-by: Oleksii Moskalenko [email protected]
What this PR does / why we need it:
Currently python SDK requires
gcloud
cli to be installed in order to extractid_token
from ServiceAccount. This is very inconvenient. This PR usesgoogle.oauth2
instead.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: