Remove type comments #1710
Merged
Remove type comments #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1710 +/- ##
===========================================
- Coverage 82.75% 69.73% -13.02%
===========================================
Files 76 74 -2
Lines 6754 6664 -90
===========================================
- Hits 5589 4647 -942
- Misses 1165 2017 +852
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
|
/retest |
Signed-off-by: Achal Shah <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HeardACat
pushed a commit
to HeardACat/feast
that referenced
this pull request
Jul 16, 2021
* Remove type comments Signed-off-by: Achal Shah <[email protected]> * Remove more type comments Signed-off-by: Achal Shah <[email protected]> * fix lint Signed-off-by: Achal Shah <[email protected]> * fix lint again by removing imports Signed-off-by: Achal Shah <[email protected]> * Use time_ns() instead of time() Signed-off-by: Achal Shah <[email protected]> Signed-off-by: CS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Type comments are no longer needed given that we support 3.7+. Also, they break mypy as of python 3.9. This PR removes all the instances of
type: Blahfrom the codebase.Which issue(s) this PR fixes:
(Too small for issue)
Does this PR introduce a user-facing change?: