-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration testing config #174
Conversation
zhilingc
commented
Apr 10, 2019
- Added rerun command and corrected trigger command
- Fixed integration test image
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test integration-batch |
/retest |
/test integration-batch |
/retest |
1 similar comment
/retest |
Related to #102? |
@thirteen37 No, this fixes some issues with the running of the integration test via CI. The triggering is already working as intended, although the integration test step is not properly throwing an error when the test fails. The changes made in this commit should fix that. See the latest postsubmit-integration-test here: http://prow.feast.ai/ |
@thirteen37 Not quite, I need this fix in so that it does throw an error when one occurs, otherwise the integration test (that does the building of the binaries) will always pass |
Closed by #197 |