Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration testing config #174

Closed
wants to merge 6 commits into from

Conversation

zhilingc
Copy link
Collaborator

  1. Added rerun command and corrected trigger command
  2. Fixed integration test image

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zhilingc

If they are not already assigned, you can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator Author

/test integration-batch

@zhilingc
Copy link
Collaborator Author

/retest

@zhilingc
Copy link
Collaborator Author

/test integration-batch

@zhilingc
Copy link
Collaborator Author

/retest

1 similar comment
@zhilingc
Copy link
Collaborator Author

/retest

@thirteen37
Copy link
Collaborator

Related to #102?

@zhilingc
Copy link
Collaborator Author

@thirteen37 No, this fixes some issues with the running of the integration test via CI. The triggering is already working as intended, although the integration test step is not properly throwing an error when the test fails. The changes made in this commit should fix that.

See the latest postsubmit-integration-test here: http://prow.feast.ai/

@thirteen37
Copy link
Collaborator

@zhilingc Sounds like you're saying that #102 is actually resolved then? Can we mark it as such or is there more work remaining?

@zhilingc
Copy link
Collaborator Author

@thirteen37 Not quite, I need this fix in so that it does throw an error when one occurs, otherwise the integration test (that does the building of the binaries) will always pass

@davidheryanto
Copy link
Collaborator

Closed by #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants