Deprecate the input parameter for FeatureViews

[felixwang9817]

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: FeatureViews have always required a batch data source as input; this argument is currently named input. This PR removes input as an argument and makes batch_source required. Since this is a breaking change, it was preceded by a deprecation warning in #1729, which was part of the 0.12 release.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Deprecates input parameter for FeatureViews

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felixwang9817
To complete the pull request process, please assign tsotnet after the PR has been reviewed.
You can assign the PR to them by writing /assign @tsotnet in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

Merging #1765 (c95df72) into master (54bbe5f) will decrease coverage by 20.47%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           master    #1765       +/-   ##
===========================================
- Coverage   84.69%   64.21%   -20.48%     
===========================================
  Files          85       82        -3     
  Lines        6297     6218       -79     
===========================================
- Hits         5333     3993     -1340     
- Misses        964     2225     +1261     

Flag	Coverage Δ
integrationtests	?
unittests	64.21% <50.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...python/feast/infra/offline_stores/offline_utils.py	45.55% <0.00%> (-46.67%)	⬇️
...tegration/feature_repos/universal/feature_views.py	100.00% <ø> (ø)
sdk/python/feast/feature_view.py	87.21% <100.00%> (-0.56%)	⬇️
.../integration/online_store/test_online_retrieval.py	17.39% <0.00%> (-82.61%)	⬇️
sdk/python/tests/utils/online_read_write_test.py	18.18% <0.00%> (-81.82%)	⬇️
...gration/registration/test_feature_service_apply.py	31.25% <0.00%> (-68.75%)	⬇️
...hon/tests/integration/registration/test_cli_gcp.py	31.70% <0.00%> (-68.30%)	⬇️
...n/tests/integration/registration/test_cli_redis.py	32.55% <0.00%> (-67.45%)	⬇️
sdk/python/feast/infra/online_stores/redis.py	30.35% <0.00%> (-64.29%)	⬇️
sdk/python/feast/infra/online_stores/dynamodb.py	30.37% <0.00%> (-60.76%)	⬇️
... and 37 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54bbe5f...c95df72. Read the comment docs.

[woop]

@felixwang9817 let's hold this for now. Pending a decision on OD transformations.

[woop]

/hold

[adchia]

A quick followup here. We decided that ODFVs need to be able to take in other feature views as input for some important use cases, so input might need to stay

[woop]

@adchia we'll probably have a different class/proto for ODFVs though. Although I think it's still smart to have this PR stay held.

[woop]

Is this PR still relevant?

[felixwang9817]

@woop I think this change might still be useful? ODFVs have an inputs parameter, but if anything that makes me want to remove the input parameter for FVs, to remove any potential confusion. I don't feel strongly; happy to close this PR.