Move apply(dummy_entity) to apply time to ensure it persists in FeatureStore

[codyjlin]

Signed-off-by: Cody Lin [email protected]

What this PR does / why we need it:
This is a follow up of #1804 and addresses changes from this comment: https://github.com/feast-dev/feast/pull/1804/files/b767eb7d42a4ae3d244693fee5fafe7ea9e4143c#r705519160

Basically, if we only apply the dummy_id at FeatureStore.init time, it might get erased in future apply calls by the user. It would be persisted by moving it to apply time.

Which issue(s) this PR fixes:

Small bug fix for #1737

Does this PR introduce a user-facing change?:

NONE

[feast-ci-bot]

Hi @codyjlin. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codyjlin]

/kind bug

[achals]

/lgtm

[codecov-commenter]

Codecov Report

Merging #1848 (63344cf) into master (b509092) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
+ Coverage   84.52%   84.58%   +0.05%     
==========================================
  Files          90       90              
  Lines        6837     6837              
==========================================
+ Hits         5779     5783       +4     
+ Misses       1058     1054       -4     

Flag	Coverage Δ
integrationtests	84.51% <100.00%> (+0.05%)	⬆️
unittests	63.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_store.py	93.14% <100.00%> (ø)
sdk/python/feast/registry.py	78.83% <0.00%> (+1.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b509092...63344cf. Read the comment docs.

[felixwang9817]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, codyjlin, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment