Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature server docs & small changes in local server #1852

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Sep 10, 2021

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it: This adds the feature server documentation to Feast. We also make a couple of small changes to the local server. Namely:

  1. Change GET to POST request
  2. Change routing from /get-online-features/ to /get-online-features, which doesn't change anything for the local server, but fixes a very ambiguous bug when using this server with AWS Lambda (which is WIP).
  3. Add experimental warning on feast serve and add it in the CLI message as well.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Document local feature server (experimental)

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #1852 (dd06ffc) into master (0dc13f0) will decrease coverage by 21.27%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1852       +/-   ##
===========================================
- Coverage   84.45%   63.17%   -21.28%     
===========================================
  Files          90       91        +1     
  Lines        6773     6963      +190     
===========================================
- Hits         5720     4399     -1321     
- Misses       1053     2564     +1511     
Flag Coverage Δ
integrationtests ?
unittests 63.17% <33.33%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/cli.py 42.58% <ø> (ø)
sdk/python/feast/feature_server.py 27.77% <33.33%> (+1.30%) ⬆️
.../integration/online_store/test_universal_online.py 16.66% <0.00%> (-83.34%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.29% <0.00%> (-80.71%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 30.32% <0.00%> (-63.12%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-62.50%) ⬇️
sdk/python/tests/data/data_creator.py 38.09% <0.00%> (-61.91%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc13f0...dd06ffc. Read the comment docs.

Signed-off-by: Tsotne Tabidze <[email protected]>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants