-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature server docs & small changes in local server #1852
Conversation
Signed-off-by: Tsotne Tabidze <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1852 +/- ##
===========================================
- Coverage 84.45% 63.17% -21.28%
===========================================
Files 90 91 +1
Lines 6773 6963 +190
===========================================
- Hits 5720 4399 -1321
- Misses 1053 2564 +1511
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Tsotne Tabidze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: This adds the feature server documentation to Feast. We also make a couple of small changes to the local server. Namely:
/get-online-features/
to/get-online-features
, which doesn't change anything for the local server, but fixes a very ambiguous bug when using this server with AWS Lambda (which is WIP).feast serve
and add it in the CLI message as well.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: