Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make serverless alpha feature #1928

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR makes AWS Lambda serverless deployments an alpha feature. It also ensures that the AWS Lambda feature server can only be deployed if the registry is on S3.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Makes AWS Lambda feature server an alpha feature

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #1928 (4a71caf) into master (a0918bf) will decrease coverage by 0.03%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1928      +/-   ##
==========================================
- Coverage   81.98%   81.95%   -0.04%     
==========================================
  Files          96       96              
  Lines        7542     7557      +15     
==========================================
+ Hits         6183     6193      +10     
- Misses       1359     1364       +5     
Flag Coverage Δ
integrationtests 73.62% <46.66%> (-0.04%) ⬇️
unittests 59.93% <46.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/aws.py 39.67% <33.33%> (-0.33%) ⬇️
sdk/python/feast/flags_helper.py 89.47% <50.00%> (-4.65%) ⬇️
sdk/python/feast/errors.py 70.00% <66.66%> (-0.08%) ⬇️
sdk/python/feast/flags.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/online_stores/datastore.py 93.44% <0.00%> (+2.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0918bf...4a71caf. Read the comment docs.

sdk/python/feast/flags.py Show resolved Hide resolved
sdk/python/feast/infra/aws.py Show resolved Hide resolved
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator Author

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Oct 7, 2021
@feast-ci-bot feast-ci-bot merged commit d0778f7 into feast-dev:master Oct 7, 2021
@felixwang9817 felixwang9817 deleted the serverless_alpha branch October 7, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants