-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify feature_store.plan to produce an InfraDiff #2211
Conversation
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2211 +/- ##
==========================================
- Coverage 85.04% 85.04% -0.01%
==========================================
Files 105 105
Lines 8387 8450 +63
==========================================
+ Hits 7133 7186 +53
- Misses 1254 1264 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
config: The RepoConfig for the current FeatureStore. | ||
desired_registry_proto: The desired registry, in proto form. | ||
""" | ||
return Infra() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nonblocking comment: does it make sense to print a message or something here? e.g. so a custom provider knows that feast plan won't cover their use case?
Not sure how we intend the SDK version of plan to be used, so maybe it doesn't make sense to log though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: This PR modifies
feature_store.plan
to produce anInfraDiff
object, which will be used to modify infrastructure as part offeast plan
.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: