Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links on documentation #2278

Merged
merged 4 commits into from
Feb 3, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Feb 3, 2022

What this PR does / why we need it:
This includes broken documentation on GitBook as well as in README files

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #2278 (1b9ee73) into master (fb995a2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2278   +/-   ##
=======================================
  Coverage   86.01%   86.01%           
=======================================
  Files         116      116           
  Lines        9810     9810           
=======================================
  Hits         8438     8438           
  Misses       1372     1372           
Flag Coverage Δ
integrationtests 74.80% <ø> (-0.29%) ⬇️
unittests 58.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb995a2...1b9ee73. Read the comment docs.

@adchia adchia changed the title [WIP] Fix broken links on documentation Fix broken links on documentation Feb 3, 2022
@adchia adchia assigned tsotnet and unassigned achals Feb 3, 2022
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
@feast-ci-bot feast-ci-bot added size/L and removed size/S labels Feb 3, 2022
Signed-off-by: Danny Chiao <[email protected]>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 77efd9e into feast-dev:master Feb 3, 2022
@adchia adchia deleted the fixBrokenLinks branch March 4, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants