Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating documentation for entity's join key #2451

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Mar 25, 2022

Signed-off-by: pyalex [email protected]

What this PR does / why we need it:

Following up on #2420

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: pyalex <[email protected]>
@pyalex pyalex requested a review from a team as a code owner March 25, 2022 00:28
@pyalex pyalex requested review from achals and removed request for a team March 25, 2022 00:28
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #2451 (4b08731) into master (ea6a9b2) will increase coverage by 1.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2451      +/-   ##
==========================================
+ Coverage   83.66%   84.87%   +1.20%     
==========================================
  Files         125      127       +2     
  Lines       10838    11424     +586     
==========================================
+ Hits         9068     9696     +628     
+ Misses       1770     1728      -42     
Flag Coverage Δ
integrationtests 75.60% <ø> (+2.31%) ⬆️
unittests 58.44% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/unit/test_data_sources.py 87.50% <0.00%> (-12.50%) ⬇️
sdk/python/feast/repo_operations.py 47.42% <0.00%> (-7.96%) ⬇️
...gration/online_store/test_push_online_retrieval.py 100.00% <0.00%> (ø)
...ython/feast/embedded_go/online_features_service.py 95.08% <0.00%> (ø)
sdk/python/feast/feature_store.py 91.13% <0.00%> (+0.29%) ⬆️
...tegration/feature_repos/universal/feature_views.py 84.61% <0.00%> (+0.74%) ⬆️
...hon/feast/infra/offline_stores/snowflake_source.py 88.61% <0.00%> (+0.81%) ⬆️
...thon/feast/infra/offline_stores/bigquery_source.py 87.06% <0.00%> (+0.86%) ⬆️
...thon/feast/infra/offline_stores/redshift_source.py 87.06% <0.00%> (+0.86%) ⬆️
...ts/integration/feature_repos/repo_configuration.py 97.16% <0.00%> (+1.06%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6a9b2...4b08731. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex pyalex changed the title chore: Updating documentation for entity's join key [WIP] chore: Updating documentation for entity's join key Mar 25, 2022
@pyalex pyalex changed the title [WIP] chore: Updating documentation for entity's join key chore: Updating documentation for entity's join key Mar 26, 2022
@feast-ci-bot feast-ci-bot merged commit b5acebf into feast-dev:master Mar 26, 2022
pyalex added a commit that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants