Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add materialize and materialize-incremental rest endpoints #3761

Merged
merged 2 commits into from
Sep 12, 2023
Merged

feat: Add materialize and materialize-incremental rest endpoints #3761

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e93562c
resolve #3760
snowron Sep 12, 2023
0dbf03a
format feature_server.py
snowron Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import json
import traceback
from typing import List, Optional
import warnings

import gunicorn.app.base
Expand All @@ -15,7 +16,8 @@
from feast.data_source import PushMode
from feast.errors import PushSourceNotFoundException
from feast.protos.feast.serving.ServingService_pb2 import GetOnlineFeaturesRequest

from dateutil import parser
from feast import utils

# TODO: deprecate this in favor of push features
class WriteToFeatureStoreRequest(BaseModel):
Expand All @@ -31,6 +33,16 @@ class PushFeaturesRequest(BaseModel):
to: str = "online"


class MaterializeRequest(BaseModel):
start_ts: str
end_ts: str
feature_views: Optional[List[str]] = None

class MaterializeIncrementalRequest(BaseModel):
end_ts: str
feature_views: Optional[List[str]] = None


def get_app(store: "feast.FeatureStore"):
proto_json.patch()

Expand Down Expand Up @@ -134,6 +146,30 @@ def write_to_online_store(body=Depends(get_body)):
def health():
return Response(status_code=status.HTTP_200_OK)

@app.post("/materialize")
def materialize(body=Depends(get_body)):
try:
request = MaterializeRequest(**json.loads(body))
store.materialize(utils.make_tzaware(parser.parse(request.start_ts)), utils.make_tzaware(
parser.parse(request.end_ts)), request.feature_views)
except Exception as e:
# Print the original exception on the server side
logger.exception(traceback.format_exc())
# Raise HTTPException to return the error message to the client
raise HTTPException(status_code=500, detail=str(e))

@app.post("/materialize-incremental")
def materialize_incremental(body=Depends(get_body)):
try:
request = MaterializeIncrementalRequest(**json.loads(body))
store.materialize_incremental(utils.make_tzaware(
parser.parse(request.end_ts)), request.feature_views)
except Exception as e:
# Print the original exception on the server side
logger.exception(traceback.format_exc())
# Raise HTTPException to return the error message to the client
raise HTTPException(status_code=500, detail=str(e))

return app


Expand Down