-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Issue-3771, fix document error as not shortcut -f option in code. #3783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achals
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
@shuchu You need to sign off your commits: https://github.com/feast-dev/feast/pull/3783/checks?check_run_id=17532312440 |
Signed-off-by: Shuchu Han <[email protected]>
sorry about this mistake. Have fixed it. |
Signed-off-by: Achal Shah <[email protected]>
* chore: Add harry to CODEOWNERS Signed-off-by: Achal Shah <[email protected]> * add path Signed-off-by: Achal Shah <[email protected]> --------- Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Achal Shah <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…st/ui (feast-dev#3802) chore: Bump @babel/traverse in /sdk/python/feast/ui Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.17.10 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…east-dev#3780) Bumps [avro](https://github.com/apache/avro) from 1.10.0 to 1.11.3. - [Release notes](https://github.com/apache/avro/releases) - [Commits](apache/avro@release-1.10.0...release-1.11.3) --- updated-dependencies: - dependency-name: avro dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: Support param timeout when persisting Signed-off-by: Hai Nguyen <[email protected]> * fix: fix java integration test Signed-off-by: Hai Nguyen <[email protected]> --------- Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
* fix: Resolve hbase hotspot issue when materializing Signed-off-by: Hai Nguyen <[email protected]> * chore: Refactor internal table id generator Signed-off-by: Hai Nguyen <[email protected]> --------- Signed-off-by: Hai Nguyen <[email protected]>
* Fix critical issue with saving results in BigQuery Need to encapsulate table path as tmp table path can contain symbols that can't be process by BigQuery without encapsulation Signed-off-by: Dmytro Miedviediev <[email protected]> * update numpy Signed-off-by: Dmytro Miedviediev <[email protected]> * revert numpy version Signed-off-by: Dmytro Miedviediev <[email protected]> --------- Signed-off-by: Dmytro Miedviediev <[email protected]>
…rialization timestamp updates (feast-dev#3789) * SAASMLOPS-767 wait for jobs to complete Signed-off-by: James Crabtree <[email protected]> * SAASMLOPS-805 Stopgap change to fix duplicate materialization of data Signed-off-by: James Crabtree <[email protected]> * SAASMLOPS-805 save BYTEWAX_REPLICAS=1 Signed-off-by: James Crabtree <[email protected]> * SAASMLOPS-809 fix bytewax workers so they only process a single file (feast-dev#6) * SAASMLOPS-809 fix bytewax workers so they only process a single file * SAASMLOPS-809 fix newlines Signed-off-by: James Crabtree <[email protected]> * SAASMLOPS-833 add configurable job timeout (feast-dev#7) * SAASMLOPS-833 add configurable job timeout * SAASMLOPS-833 fix whitespace Signed-off-by: James Crabtree <[email protected]> * develop Run large materializations in batches of pods Signed-off-by: James Crabtree <[email protected]> * master Set job_batch_size at least equal to max_parallelism Signed-off-by: James Crabtree <[email protected]> * master clarity max_parallelism description Signed-off-by: James Crabtree <[email protected]> * master resolve bug that causes materialization to continue after job error Signed-off-by: James Crabtree <[email protected]> * master resolve bug causing pod logs to not be printed Signed-off-by: James Crabtree <[email protected]> --------- Signed-off-by: James Crabtree <[email protected]>
…ts (feast-dev#3803) Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.18. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.16...1.26.18) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Hai Nguyen <[email protected]>
…east-dev#3812) fix: Add async refresh to prevent synchronous refresh in main thread for http feature server Signed-off-by: Hai Nguyen <[email protected]>
fix: bytewax engine create configmap from object Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
…t-dev#3896) * [docs] updated development guide to include compiling the protos Signed-off-by: franciscojavierarceo <[email protected]> * adding note on spinning up the docker image Signed-off-by: franciscojavierarceo <[email protected]> --------- Signed-off-by: franciscojavierarceo <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
chore: set upper bound for moto package Signed-off-by: Hai Nguyen <[email protected]>
Modify the README to point to correct project list Signed-off-by: Twinkll Sisodia <[email protected]>
…ev#3936) rewrite spark materilization engine to use mapInPandas Signed-off-by: tokoko <[email protected]>
…#3922) * chore: Loosen fsspec requirements to allow recent releases (I'm not sure the project has a super consistent pattern for when to specify a maximum version, but was going for the smallest possible change.) Signed-off-by: Chris Burroughs <[email protected]> * drop redundant fsspec now that this is in another extra Signed-off-by: Chris Burroughs <[email protected]> * post rebase regen Signed-off-by: Chris Burroughs <[email protected]> --------- Signed-off-by: Chris Burroughs <[email protected]>
Signed-off-by: Shuchu Han <[email protected]>
auto-merge was automatically disabled
February 16, 2024 22:19
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The code in cli.py (line 75) doest not configure shortcut:
@click.option( "--feature-store-yaml", help="Override the directory where the CLI should look for the feature_store.yaml file.", )
Which issue(s) this PR fixes:
Fixes #3771