Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e batch test in v0.3-branch #412

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Fix e2e batch test in v0.3-branch #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions tests/e2e/bq-batch-retrieval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@
from google.protobuf.duration_pb2 import Duration
from pandavro import to_avro

pd.set_option('display.max_columns', None)
pd.set_option("display.max_columns", None)

# How long we should wait for the Beam job to be ready for ingestion after running `feast apply`.
# When using DirectRunner, 20 seconds is a reasonable time from past observations.
WAIT_TIME_IN_SECONDS_FOR_FEAST_APPLY = 20


@pytest.fixture(scope="module")
def core_url(pytestconfig):
Expand Down Expand Up @@ -62,6 +67,7 @@ def test_get_batch_features_with_file(client):
)

client.apply(file_fs1)
time.sleep(WAIT_TIME_IN_SECONDS_FOR_FEAST_APPLY)
file_fs1 = client.get_feature_set(name="file_feature_set", version=1)

N_ROWS = 10
Expand Down Expand Up @@ -99,6 +105,7 @@ def test_get_batch_features_with_gs_path(client, gcs_path):
)

client.apply(gcs_fs1)
time.sleep(WAIT_TIME_IN_SECONDS_FOR_FEAST_APPLY)
gcs_fs1 = client.get_feature_set(name="gcs_feature_set", version=1)

N_ROWS = 10
Expand Down Expand Up @@ -149,7 +156,7 @@ def test_order_by_creation_time(client):
max_age=Duration(seconds=100),
)
client.apply(proc_time_fs)
time.sleep(10)
time.sleep(WAIT_TIME_IN_SECONDS_FOR_FEAST_APPLY)
proc_time_fs = client.get_feature_set(name="processing_time", version=1)

time_offset = datetime.utcnow().replace(tzinfo=pytz.utc)
Expand Down Expand Up @@ -188,13 +195,17 @@ def test_additional_columns_in_entity_table(client):
max_age=Duration(seconds=100),
)
client.apply(add_cols_fs)
time.sleep(10)
time.sleep(WAIT_TIME_IN_SECONDS_FOR_FEAST_APPLY)
add_cols_fs = client.get_feature_set(name="additional_columns", version=1)

N_ROWS = 10
time_offset = datetime.utcnow().replace(tzinfo=pytz.utc)
features_df = pd.DataFrame(
{"datetime": [time_offset] * N_ROWS, "entity_id": [i for i in range(N_ROWS)], "feature_value": ["abc"] * N_ROWS}
{
"datetime": [time_offset] * N_ROWS,
"entity_id": [i for i in range(N_ROWS)],
"feature_value": ["abc"] * N_ROWS,
}
)
client.ingest(add_cols_fs, features_df)

Expand Down Expand Up @@ -225,7 +236,7 @@ def test_point_in_time_correctness_join(client):
max_age=Duration(seconds=100),
)
client.apply(historical_fs)
time.sleep(10)
time.sleep(WAIT_TIME_IN_SECONDS_FOR_FEAST_APPLY)
historical_fs = client.get_feature_set(name="historical", version=1)

time_offset = datetime.utcnow().replace(tzinfo=pytz.utc)
Expand Down Expand Up @@ -271,11 +282,11 @@ def test_multiple_featureset_joins(client):
)

client.apply(fs1)
time.sleep(10)
time.sleep(WAIT_TIME_IN_SECONDS_FOR_FEAST_APPLY)
fs1 = client.get_feature_set(name="feature_set_1", version=1)

client.apply(fs2)
time.sleep(10)
time.sleep(WAIT_TIME_IN_SECONDS_FOR_FEAST_APPLY)
fs2 = client.get_feature_set(name="feature_set_2", version=1)

N_ROWS = 10
Expand Down