Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Daniele and Lokesh as Approvers and Reviewers #4672

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

franciscojavierarceo
Copy link
Member

What this PR does / why we need it:

Add Daniele and Lokesh as Approvers and Reviewers

Which issue(s) this PR fixes:

N/A

Misc

@tokoko
Copy link
Collaborator

tokoko commented Oct 23, 2024

This is not gonna work unfortunately, OWNERS file is supposed to be read by prow, which I'm pretty sure is not longer active, not sure who was hosting it in the first place.

@franciscojavierarceo
Copy link
Member Author

Wiping OWNERS file and updating CODEOWNERS to have reviewers too. I think that's a simple enough process for now?

We can have team members at Red Hat add prow support later but for now OWNERS is a distraction then.

@tokoko
Copy link
Collaborator

tokoko commented Oct 23, 2024

just making sure.. CODEOWNERS just means the group will be requested a review if a PR touches any of those folders. It doesn't actually give any new permissions to either approve or merge.

@franciscojavierarceo
Copy link
Member Author

I have that configured in the repo settings.

Screenshot 2024-10-23 at 12 31 57 PM

@tokoko
Copy link
Collaborator

tokoko commented Oct 23, 2024

Oh.. okay. does that mean require a review from all code owners or at least one? We might be shooting ourselves in the foot if everyone needs to approve all PRs 😆

@franciscojavierarceo
Copy link
Member Author

Nope! There's configuration to do round robin and only requiring one approver.

@franciscojavierarceo
Copy link
Member Author

You only need one approver before merging.

@franciscojavierarceo
Copy link
Member Author

can you approve? :D

@tokoko tokoko merged commit 5291289 into master Oct 23, 2024
26 checks passed
emgeee pushed a commit to emgeee/feast that referenced this pull request Oct 23, 2024
)

* chore: Add Daniele and Lokesh as Approvers and Reviewers

Add Daniele and Lokesh as Approvers and Reviewers

* Delete OWNERS

* Update CODEOWNERS
emgeee pushed a commit to emgeee/feast that referenced this pull request Oct 23, 2024
)

* chore: Add Daniele and Lokesh as Approvers and Reviewers

Add Daniele and Lokesh as Approvers and Reviewers

* Delete OWNERS

* Update CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants