-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Clickhouse offline store #4725
base: master
Are you sure you want to change the base?
feat: Clickhouse offline store #4725
Conversation
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Signed-off-by: Tomasz Wrona <[email protected]>
Hi @iamhatesz , I patched the requirements on your branch to hopefully fix the errors being thrown by the checks
Merge at your earliest convenience. Looking forward to using this. ATM, running on PG and would like to move to CH asap |
Bunch of stuff failing here, think you also need to rebase. Let me know if you need some help! |
@zerafachris @franciscojavierarceo thanks! I will take a look and push some updates. |
What this PR does / why we need it:
This PR adds a new contrib offline store backed by Clickhouse.
Which issue(s) this PR fixes:
Lack of Clickhouse support :)
Misc
The implementation is heavily based on the Postgres store and tested against it. The resulting features were identical to the point that it's possible with two different backends (e.g., different data types).
I added a helper to run integration tests:
make test-python-universal-clickhouse-offline
. Unfortunately, 3 test cases are failing:This is because Clickhouse doesn't support
Nullable(Array(...))
type. I could have addedtest_universal_types
to the ignore list, but I thought it's worth keeping it on, as many other test cases from this test are passing.