-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update uv version to latest #5086
Conversation
992abe6
to
1af4a70
Compare
@@ -70,8 +70,8 @@ gcp = [ | |||
"google-cloud-bigtable>=2.11.0,<3", | |||
"fsspec<=2024.9.0", | |||
] | |||
ge = ["great_expectations>=0.15.41"] | |||
go = ["cffi~=1.15.0"] | |||
ge = ["great_expectations>=0.15.41,<1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
temp_module = importlib.import_module(full_name) | ||
if is_pkg: | ||
next_packages.append(temp_module) | ||
if "ikv" not in full_name and "milvus" not in full_name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: ntkathole <[email protected]>
ge = ["great_expectations>=0.15.41"] | ||
go = ["cffi~=1.15.0"] | ||
ge = ["great_expectations>=0.15.41,<1"] | ||
go = ["cffi>=1.15.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ikv needs cffi>=1.16.0
https://github.com/inlinedio/ikv-store/blob/master/ikv-python-client/pyproject.toml#L29
What this PR does / why we need it:
This PR updates the uv version to latest. Using old version of uv, it was removing required dependencies while compiling the pip.
New version is ensuring more accurate resolution of package versions and requirements, also, prevents unnecessary removals by better handling version conflicts and sub-dependencies.
Which issue(s) this PR fixes:
This was blocking CI to pass while trying to add new add on.