-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeatureSets are delivered to Ingestion Job through Kafka #792
Conversation
/test test-end-to-end-batch-dataflow |
|
||
@Autowired | ||
public SpecService( | ||
FeatureSetRepository featureSetRepository, | ||
StoreRepository storeRepository, | ||
ProjectRepository projectRepository, | ||
Source defaultSource) { | ||
Source defaultSource, | ||
KafkaTemplate<String, FeatureSetProto.FeatureSetSpec> specPublisher) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to flag that even though I agree with the approach we are taking with Spring and Kafka, I do consider it technical debt that we are going into. Ideally the life cycle of jobs and the updates of feature sets to those jobs would fully encapsulated in the job management layer, especially if we ever want to separate job management from core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be more than happy to move this communication responsibility to JobService, but right now JobService is dependant on SpecService and I need publishing to kafka be synchronous part of applyFeatureSet. So yeah, currently it's a tech debt.
/test test-end-to-end-batch-dataflow |
ingestion/src/main/java/feast/ingestion/transform/specs/FilterRelevantFunction.java
Show resolved
Hide resolved
ingestion/src/main/java/feast/ingestion/transform/specs/KafkaRecordToFeatureSetSpec.java
Show resolved
Hide resolved
ingestion/src/test/java/feast/ingestion/transform/specs/FilterRelevantTest.java
Outdated
Show resolved
Hide resolved
…eatureSet version switch to spring-kafka (configs) specService send message to kafka & expect ack & update status accordingly jobs runner to send source & specs config (source + ack) ingestion job to read specs from kafka and send ack return featureSets in ingestionJob generate uniq topic name for each test run prevent listJobs from failing when job failed on start
/test test-end-to-end-batch-dataflow |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
SpecService & IngestionJob are now communicate through kafka topics, which makes job restarts on FeatureSet change obsolete. Now job restarted only when subscription configuration of store was changed.
Communication Flow:
specs-topic
and set FeatureSet status to Pendingspecs-ack-topic
Which issue(s) this PR fixes:
Fixes #761
Does this PR introduce a user-facing change?:
No