This repository has been archived by the owner on Feb 6, 2018. It is now read-only.
Adds support for custom headers via params #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs #12. |
| @@ -10,6 +10,7 @@ export default class Base { | |||
| } | |||
|
|
|||
| makeUrl(params, id) { | |||
| params = params || {}; | |||
There was a problem hiding this comment.
this can be makeUrl(params = {}, id)
There was a problem hiding this comment.
Our linter prevents it. I think you can put a jshint comment I guess.
daffl
changed the title
ekryski
added a commit
that referenced
this pull request
Feb 8, 2016
Adds support for custom headers via hooks. Closes #12.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to set
params.headersand those get passed to each transport appropriately. This is primarily to support auth.