This repository has been archived by the owner on Feb 6, 2018. It is now read-only.
Allow using default fetch headers for all requests #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In situation where the server requires some specific headers, this allows to set them once and then use on each request
```js
const feathers = require('feathers')
const rest = require('feathers-rest/client')
const fetch = require('node-fetch')
const headers = {
whatever: 'I need'
}
const restClient = rest('https://my.url').fetch(fetch, {headers})
const app = feathers().configure(restClient)
```
|
Currently only |
|
That is a great change. Would you mind adding the same thing for jQuery (at https://github.com/feathersjs/feathers-rest/blob/master/src/client/jquery.js#L5) as well? |
|
will do tomorrow, thanks for quick look! |
Should be enough to allow common headers with each REST call via jQuery ajax
```js
const headers = {
whatever: 'I need'
}
const restClient = rest('https://my.url').jquery(jQuery, {headers})
const app = feathers().configure(restClient)
```
Relevant to jQuery ajax http://api.jquery.com/jquery.ajax/#jQuery-ajax-settings "headers" property
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situation where the server requires some specific headers, this allows to set them once and then use on each request