Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feathr UI: search does not return correct result when fired by pressing enter #391

Closed
blrchen opened this issue Jun 24, 2022 · 0 comments · Fixed by #405
Closed

Feathr UI: search does not return correct result when fired by pressing enter #391

blrchen opened this issue Jun 24, 2022 · 0 comments · Fixed by #405
Assignees
@blrchen

Comments

@blrchen
Copy link
Collaborator

blrchen commented Jun 24, 2022

Search can be triggered by clicking search button or pressing enter. Currently the returned results are different for these two behaviors.

The root cause is project name is not bind correctly in api request for pressing enter event:
http://localhost:8000/api/v1/projects/[object%20Object]/features?code=&keyword=time&page=1&limit=10, the correct one should be http://localhost:8000/api/v1/projects/feathr_ci_registry_12_33_182947/features?code=&keyword=time&page=1&limit=10
@blrchen blrchen self-assigned this Jun 24, 2022
@blrchen blrchen mentioned this issue Jun 27, 2022
Merged
blrchen added a commit that referenced this issue Jun 27, 2022
@blrchen
Fix feature list search box onPressEnter event does not fire search c…
260621b 
…orrectly (#405)

This PR fixes the issue pressing enter on search button does not return correct results.

Closes #391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blrchen blrchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feathr UI: Fix press enter on search button does not return correct results feathr-ai/feathr
1 participant
@blrchen