Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature names conflicts check and auto-correction #1024

Merged
merged 18 commits into from
Feb 14, 2023
Merged

Feature names conflicts check and auto-correction #1024

merged 18 commits into from
Feb 14, 2023

Conversation

enya-yx
Copy link
Collaborator

@enya-yx enya-yx commented Jan 31, 2023 •
edited
Loading

Description

  • Apply auto-correction in spark to solve feature names conflicts
  • Expose auto-correction in python client to support this feature
  • Support checking conflicts in python client when auto-correction is enabled
  • Provide test cases at both scala and python
  • Provide related docs

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@enya-yx enya-yx changed the title Enya/feature names2 Feature names conflicts auto-correction Jan 31, 2023
@enya-yx enya-yx added the safe to test Tag to execute build pipeline for a PR from forked repo label Jan 31, 2023
@enya-yx enya-yx removed the safe to test Tag to execute build pipeline for a PR from forked repo label Jan 31, 2023
@enya-yx enya-yx added the safe to test Tag to execute build pipeline for a PR from forked repo label Feb 1, 2023
@jainr jainr requested a review from Yuqing-cat February 1, 2023 05:55
@enya-yx enya-yx changed the title Feature names conflicts auto-correction Feature names conflicts check and auto-correction Feb 1, 2023
@enya-yx enya-yx merged commit a7d5b20 into feathr-ai:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blrchen blrchen blrchen approved these changes

@Yuqing-cat Yuqing-cat Yuqing-cat approved these changes

@jaymo001 jaymo001 Awaiting requested review from jaymo001

@loomlike loomlike Awaiting requested review from loomlike

@xiaoyongzhu xiaoyongzhu Awaiting requested review from xiaoyongzhu

@windoze windoze Awaiting requested review from windoze

Assignees
No one assigned
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enya-yx @blrchen @Yuqing-cat